fix(core): keep FileStore invites in the membership operation maps - #36
Merged
Conversation
inviteToRoom and declineInvite still mutated the invited array directly after joinRoom switched to re-deriving the view from the per-agent operation maps, so any later join re-derived invited from maps that never recorded those invites and wiped every pending invitation. Record the operations with a version bump as the MeshStore sites do, and cover the store with tests: a pending invite survives an unrelated join, decline and kick clear the view consistently, re-invitation after a decline outranks the leave, and joining through an invitation consumes it. Also surface unparseable stored records instead of reading them as an empty mesh: listAgents returned an empty list for any error inside the read-and-parse loop, so a record written by an older build (missing the required version field) silently read as no agents at all. Only a missing registry directory is a legitimate empty list now.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
🎉 This PR is included in version 1.27.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35, fixes #32.
#35 — pending invites were wiped by any later join. PR #34 switched FileStore's
joinRoomto re-derive theinvitedview from the per-agent operation maps but leftinviteToRoomanddeclineInvitemutating the array directly, so a join re-derivedinvitedfrom maps that never recorded those invites — every pending invitation vanished. Both sites now record their operations with a version bump, exactly as the MeshStore sites do.#32 — unparseable records read as an empty mesh.
listAgentsreturned[]for any error inside the read-and-parse loop, so a record written by an older build (missing the requiredversionfield) silently read as no agents at all. Only a missing registry directory is a legitimate empty list now; everything else propagates, per the fail-loudly convention. The default-the-field-to-1 migration alternative was rejected when #32 was filed and stays rejected.The store also gains its first test coverage (wired into
pnpm test): a pending invite survives an unrelated join, decline/kick clear the view consistently, re-invitation after a decline outranks the leave, joining through an invitation consumes it, unparseable records raise, and a fresh store lists no agents. Full suite 28 tests green, lint/typecheck/build clean.